Mirror/frr
0
0
Fork 1
mirror of https://github.com/FRRouting/frr.git synced 2025-04-30 21:47:15 +02:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

zebra: Don't bind netns ID netlink socket to mcast groups

Browse source 
The netlink socket in `zebra_ns_id_get()` is only used to get netns id.
There's no need to subscribe to multicast groups. In some heavy-loaded
cases, unexpected notification races with normal reply message and
causes failure:

    zebra[110338]: [NMNEE-JJKPF][EC 4043309094] netlink recvmsg: bad sequence number 505ac8 (expected 66ea845f)

BTW, to subscribe to RTNLGRP_NSID, `nl_groups` should be
`1 << (RTNLGRP_NSID - 1)`. This code has never worked as expected.

Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
This commit is contained in:
Xiao Liang 2024-09-18 15:58:53 +08:00
parent ac56da1f50
commit 138d8a2d77
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
zebra/zebra_netns_id.c
View file

@ -181,7 +181,6 @@ ns_id_t zebra_ns_id_get(const char *netnspath, int fd_param)
} }
memset(&snl, 0, sizeof(snl)); memset(&snl, 0, sizeof(snl));
snl.nl_family = AF_NETLINK; snl.nl_family = AF_NETLINK;
snl.nl_groups = RTNLGRP_NSID;
snl.nl_pid = 0; /* AUTO PID */ snl.nl_pid = 0; /* AUTO PID */
ret = bind(sock, (struct sockaddr *)&snl, sizeof(snl)); ret = bind(sock, (struct sockaddr *)&snl, sizeof(snl));
if (ret < 0) { if (ret < 0) {